Remove lifecycle args on dynamodb

[nitrocode]

what

• Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
• Remove the lifecycle ignore changes for billing and read/write units

why

• We're not using autoscaling so why ignore these arguments

references

• Closes Remove the read_capacity and write_capacity from lifecycle change ignore #89

[bridgecrew]

Bridgecrew has found 3 infrastructure configuration errors in this PR ⬇️

[bridgecrew]

  DynamoDB Tables do not have Auto Scaling enabled
    Resource: aws_dynamodb_table.with_server_side_encryption | ID: BC_AWS_GENERAL_44

How to Fix

resource "aws_dynamodb_table" "pass" {
  name           = "user"
  hash_key       = "user-id"
  billing_mode   = "PROVISIONED"
  read_capacity  = 10
  write_capacity = 10
  attribute {
    name = "user-id"
    type = "S"
  }
}

resource "aws_appautoscaling_target" "pass" {
  resource_id        = "table/${aws_dynamodb_table.pass.name}"
  scalable_dimension = "dynamodb:table:ReadCapacityUnits"
  service_namespace  = "dynamodb"
  min_capacity       = 1
  max_capacity       = 15
}

resource "aws_appautoscaling_policy" "pass" {
  name               = "rcu-auto-scaling"
  service_namespace  = aws_appautoscaling_target.pass.service_namespace
  scalable_dimension = aws_appautoscaling_target.pass.scalable_dimension
  resource_id        = aws_appautoscaling_target.pass.resource_id
  policy_type        = "TargetTrackingScaling"

  target_tracking_scaling_policy_configuration {
    predefined_metric_specification {
      predefined_metric_type = "RDSReaderAverageCPUUtilization"
      predefined_metric_type = "DynamoDBReadCapacityUtilization"
    }

// or:
    
resource "aws_dynamodb_table" "pass_on_demand" {
  name           = "user"
  hash_key       = "user-id"
  billing_mode   = "PAY_PER_REQUEST"

  attribute {
    name = "user-id"
    type = "S"
  }
}

Description

Checks if DynamoDB tables have autoscaling configuration. Note that for tables with billing_mode = "PAY_PER_REQUEST" such configuration is embedded by default.

[bridgecrew]

  Unencrypted DynamoDB Tables
    Resource: aws_dynamodb_table.without_server_side_encryption | ID: BC_AWS_GENERAL_52

How to Fix

resource "aws_dynamodb_table" "basic-dynamodb-table" {
              name           = "GameScores"
              billing_mode   = "PROVISIONED"
              read_capacity  = 20
              write_capacity = 20
              hash_key       = "UserId"
              range_key      = "UserId"
            
              attribute {
                name = "UserId"
                type = "S"
              }
           
              server_side_encryption {
                  enabled = true
              }
            } 

Description

Checks if the Amazon DynamoDB tables are encrypted.

[bridgecrew]

  DynamoDB Tables do not have Auto Scaling enabled
    Resource: aws_dynamodb_table.without_server_side_encryption | ID: BC_AWS_GENERAL_44

How to Fix

resource "aws_dynamodb_table" "pass" {
  name           = "user"
  hash_key       = "user-id"
  billing_mode   = "PROVISIONED"
  read_capacity  = 10
  write_capacity = 10
  attribute {
    name = "user-id"
    type = "S"
  }
}

resource "aws_appautoscaling_target" "pass" {
  resource_id        = "table/${aws_dynamodb_table.pass.name}"
  scalable_dimension = "dynamodb:table:ReadCapacityUnits"
  service_namespace  = "dynamodb"
  min_capacity       = 1
  max_capacity       = 15
}

resource "aws_appautoscaling_policy" "pass" {
  name               = "rcu-auto-scaling"
  service_namespace  = aws_appautoscaling_target.pass.service_namespace
  scalable_dimension = aws_appautoscaling_target.pass.scalable_dimension
  resource_id        = aws_appautoscaling_target.pass.resource_id
  policy_type        = "TargetTrackingScaling"

  target_tracking_scaling_policy_configuration {
    predefined_metric_specification {
      predefined_metric_type = "RDSReaderAverageCPUUtilization"
      predefined_metric_type = "DynamoDBReadCapacityUtilization"
    }

// or:
    
resource "aws_dynamodb_table" "pass_on_demand" {
  name           = "user"
  hash_key       = "user-id"
  billing_mode   = "PAY_PER_REQUEST"

  attribute {
    name = "user-id"
    type = "S"
  }
}

Description

Checks if DynamoDB tables have autoscaling configuration. Note that for tables with billing_mode = "PAY_PER_REQUEST" such configuration is embedded by default.

[nitrocode]

/test all

[nitrocode]

I checked with @mcalhoun and there is no reason to keep this here for compliance.