Optional attribute variable #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriy-lukyanchikov
requested review from
Gowiem and
brcnblc
and removed request for
a team
|
/test all |
|
rebuild the readme because for some reason the test was failed, can you please run tests again? @nitrocode |
|
/test all |
Gowiem
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
add_attribute_tagthat will control creation of additional attributeacceptedfor accepted andrequsterfor requesterwhy
This module can be used for creating cross-account and same account vpc peering. The case si next: if use dynamic aws creds in loop, but different attribute tag for accepted and the requester will conflict with each other for same account vpc peering. Also some time its not needed to add any additional attributes