Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated data source 'aws_subnet_ids' #64

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Replace deprecated data source 'aws_subnet_ids' #64

merged 2 commits into from
Jul 7, 2022

Conversation

gberenice
Copy link
Contributor

what

  • Data source aws_subnet_ids was replaced with aws_subnet for requester. This was already implemented for accepter.

why

  • aws_subnet_ids has been deprecated and will be removed.

references

@gberenice gberenice requested review from a team as code owners July 7, 2022 14:52
@gberenice gberenice requested review from nitrocode and SweetOps and removed request for a team July 7, 2022 14:52
@Gowiem
Copy link
Member

Gowiem commented Jul 7, 2022

/test all

@Gowiem Gowiem self-requested a review July 7, 2022 14:58
@Gowiem
Copy link
Member

Gowiem commented Jul 7, 2022

Related to #62 where we changed aws_subnet_ids => aws_subents.

Gowiem
Gowiem approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work @gberenice!!

@Gowiem Gowiem added the patch A minor, backward compatible change label Jul 7, 2022
@Gowiem Gowiem merged commit d6a5b18 into cloudposse:master Jul 7, 2022
@gberenice
Copy link
Contributor Author

Solid work @gberenice!!

That was an extremely fast review 😄 Thank you!

@Gowiem
Copy link
Member

Gowiem commented Jul 7, 2022

@gberenice Haha I see you or @olhabilan pop up in my email and I jump into action! I wouldn't leave you two hanging 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode was automatically assigned from cloudposse/contributors

@SweetOps SweetOps Awaiting requested review from SweetOps SweetOps was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gberenice @Gowiem @cloudpossebot