Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize input names as part of "Security group" upgrade #100

Merged
merged 8 commits into from
Oct 15, 2021
Merged

Normalize input names as part of "Security group" upgrade #100

merged 8 commits into from
Oct 15, 2021

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Oct 9, 2021

what

  • Normalize input names according to current Cloud Posse standards
  • Deprecate old input names
  • Add option to create IPv6 egress-only internet gateway

why

  • Part of overhaul of all modules to bring consistency
  • Provide backward compatibility while encouraging use of new variable names
  • Feature request Egress only internet gateway #93

references

@Nuru Nuru requested review from a team as code owners October 9, 2021 09:30
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Oct 9, 2021

/test all

@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Oct 9, 2021

/test all

aknysh
aknysh reviewed Oct 9, 2021
View reviewed changes
variables-deprecated.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 9, 2021
View reviewed changes
variables-deprecated.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 9, 2021
View reviewed changes
variables-deprecated.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 9, 2021
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 9, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nuru LGTM, please see comments

nitrocode
nitrocode reviewed Oct 10, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
max-lobur
max-lobur previously approved these changes Oct 11, 2021
View reviewed changes
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Oct 15, 2021

/test all

nitrocode
nitrocode reviewed Oct 15, 2021
View reviewed changes
variables-deprecated.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode previously approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpick but looks good to me

aknysh
aknysh reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nitpick by @nitrocode

@Nuru @nitrocode
rename variable in description
dc8685e 
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
aknysh
aknysh previously approved these changes Oct 15, 2021
View reviewed changes
@mergify mergify bot dismissed aknysh’s stale review October 15, 2021 18:44

This Pull Request has been updated, so we're dismissing all reviews.

@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Oct 15, 2021

/test all

@Nuru Nuru merged commit a3c4b15 into master Oct 15, 2021
@Nuru Nuru deleted the security-group branch October 15, 2021 19:03
@nitrocode nitrocode mentioned this pull request Oct 26, 2021
Closed
@nitrocode nitrocode mentioned this pull request Nov 5, 2021
Merged
@renovate renovate bot mentioned this pull request Jun 20, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@max-lobur max-lobur max-lobur left review comments

@nitrocode nitrocode nitrocode left review comments

@osterman osterman Awaiting requested review from osterman

@korenyoni korenyoni Awaiting requested review from korenyoni

@danjbh danjbh Awaiting requested review from danjbh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updated behavior, features, and variable names Egress only internet gateway
5 participants
@Nuru @max-lobur @aknysh @nitrocode @cloudpossebot