Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fix var.enabled conditional Logic within for_each Meta-argument in vpc-endpoints Submodule #84

Merged
merged 1 commit into from
May 4, 2021
Merged

Fix: fix var.enabled conditional Logic within for_each Meta-argument in vpc-endpoints Submodule #84

merged 1 commit into from
May 4, 2021

Conversation

korenyoni
Copy link
Contributor

@korenyoni korenyoni commented May 4, 2021 •
edited

what

  • Fix var.enabled conditional logic within for_each meta-argument in vpc-endpoints submodule

why

  • set() is neither a real Terraform function nor will the valid toset([]) work in this instance of for_each (due to type mismatch in the ternary operator), however due to the short-circuit with enabled=true, this wasn't picked up in tests.

references

@korenyoni
Fix conditional logic within for_each meta-argument — set() is neithe…
1ce0eef 
…r a real Terraform function nor will toset([]) work in this instance of for_each, however the short-circuit with enabled=true didn't have this picked up in tests.
@korenyoni korenyoni requested review from a team as code owners May 4, 2021 14:05
@korenyoni korenyoni requested a review from aknysh May 4, 2021 14:05
@korenyoni
Copy link
Contributor Author

/test all

@korenyoni korenyoni merged commit 17fcb3c into master May 4, 2021
@korenyoni korenyoni deleted the fix/submodule-for-each-conditional branch May 4, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@korenyoni @osterman