Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ip_set support #49

Closed
wants to merge 13 commits into from
Closed

Add ip_set support #49

wants to merge 13 commits into from

Conversation

Sytten
Copy link
Contributor

@Sytten Sytten commented Aug 17, 2023

what

  • Add ip_set variable in ip_set_reference_statement_rules to create IP Set automatically

why

  • If the IP set is not shared, there is no need to have separate from the WAF module
  • It allows a user of atmos to continue defining all their rules in yaml, otherwise they have to use tf code to forward the ARN to this module

Sytten
Sytten commented Aug 17, 2023
View reviewed changes
rules.tf Outdated Show resolved Hide resolved
@Sytten Sytten marked this pull request as ready for review August 17, 2023 19:40
@Sytten Sytten requested review from a team as code owners August 17, 2023 19:40
@aknysh
Copy link
Member

aknysh commented Aug 17, 2023

@Sytten thank you.

Please run the following commands and commit the changes

make init
make github/init
make readme

@Sytten Sytten closed this Aug 17, 2023
@Sytten
Copy link
Contributor Author

Sytten commented Aug 17, 2023

@aknysh I reopened it #50 sorry about that. Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sytten @aknysh