Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure provider does not use version >= 2.9 #20

Closed
wants to merge 2 commits into from
Closed

fix: ensure provider does not use version >= 2.9 #20

wants to merge 2 commits into from

Conversation

jhosteny
Copy link
Contributor

The GitHub provider introduced a breaking change with the minor bump
to version 2.9.0, by removing a number of configuration options. This
included the 'anonymous' flag, which is expected to exist by this
module. Prevent this provder version, or later, from being used for now.
For reference, see
https://github.com/terraform-providers/terraform-provider-github/issues/502.

what

  • Disallow a provider version of 2.9.0 or greater for now

why

  • Ensure the options on the provider needed by this version of the module are still available

references

The GitHub provider introduced a breaking change with the minor bump
to version 2.9.0, by removing a number of configuration options. This
included the 'anonymous' flag, which is expected to exist by this
module. Prevent this provder version, or later, from being used for now.
For reference, see
https://github.com/terraform-providers/terraform-provider-github/issues/502.
@jhosteny
Copy link
Contributor Author

/test all

@jhosteny
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor

Sorry I did not see this PR and I created another one that basically did the same.

@jhosteny
Copy link
Contributor Author

jhosteny commented Jul 1, 2020

@jamengual no worries, thanks

@jhosteny jhosteny closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants