Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove symlink, polish documentation #101

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Remove symlink, polish documentation #101

merged 4 commits into from
Aug 28, 2020

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Aug 28, 2020

what

  • Replace symbolic link to context.tf (examples/autoscalinggroup/context.tf) with copy of file
  • Move module to top of context.tf and clean up documentation comments inside the file

why

  • Terraform clones the whole repo, not just the top directory, and the symbolic link causes problems for some IDEs
  • Module contains version number and source URL, which should be at the top of the file

@Nuru Nuru added the patch A minor, backward compatible change label Aug 28, 2020
@Nuru Nuru requested a review from a team as a code owner August 28, 2020 02:18
@Nuru Nuru requested a review from a team as a code owner August 28, 2020 02:35
@Nuru Nuru requested review from SweetOps and brcnblc and removed request for a team August 28, 2020 02:35
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Aug 28, 2020

/test all

osterman
osterman previously approved these changes Aug 28, 2020
View reviewed changes
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Aug 28, 2020

/rebuild-readme

@osterman
Copy link
Member

/test all

@Nuru Nuru merged commit b3a0a44 into master Aug 28, 2020
@Nuru Nuru deleted the unsymlink branch August 28, 2020 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@SweetOps SweetOps Awaiting requested review from SweetOps

@brcnblc brcnblc Awaiting requested review from brcnblc

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nuru @osterman @actions-bot