Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unignored draft prs if no pr labels #100

Merged
merged 3 commits into from May 5, 2022
Merged

Conversation

nitrocode
Copy link
Member

what

  • Fix unignored draft prs

why

  • There is an issue if a draft PR has zero PR labels, the push proposed policy will still trigger a plan
  • This will explicitly set an ignore on both conditions: 1) if draft and no spacelift-trigger label and 2) if draft and no labels

references

N/A

@nitrocode nitrocode added the patch A minor, backward compatible change label May 4, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022

opa test result

[INFO] Testing for catalog/policies/access.default.rego...
PASS: 1/1
[INFO] Checking test coverage for catalog/policies/access.default.rego...
PASS: coverage 100%
[ERROR] catalog/policies/git_push.default.rego: test file not found
[ERROR] catalog/policies/git_push.head-diff.rego: test file not found
[ERROR] catalog/policies/git_push.proposed-run.rego: test file not found
[ERROR] catalog/policies/git_push.tracked-run.rego: test file not found
[INFO] Testing for catalog/policies/plan.default.rego...
PASS: 2/2
[INFO] Checking test coverage for catalog/policies/plan.default.rego...
PASS: coverage 100%
[ERROR] catalog/policies/trigger.administrative.rego: test file not found
[ERROR] catalog/policies/trigger.dependencies.rego: test file not found
[INFO] Testing for catalog/policies/trigger.retries.rego...
PASS: 5/5
[INFO] Checking test coverage for catalog/policies/trigger.retries.rego...
PASS: coverage 100%

@nitrocode nitrocode marked this pull request as ready for review May 5, 2022 00:12
@nitrocode nitrocode requested review from a team as code owners May 5, 2022 00:12
@nitrocode
Copy link
Member Author

/test test/bats

@nitrocode
Copy link
Member Author

/test test/readme

@nitrocode nitrocode merged commit 5c91209 into master May 5, 2022
@nitrocode nitrocode deleted the fix-unignored-draft-prs branch May 5, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants