Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test/run/in-docker #45

Closed
wants to merge 2 commits into from
Closed

add test/run/in-docker #45

wants to merge 2 commits into from

Conversation

hans-d
Copy link

@hans-d hans-d commented Mar 8, 2024

what

  • add test/run/in-docker target
  • adds AWS_ENDPOINT_URL

why

  • use generic target in test harness, vs specific per repositpry
  • allows for bulk update of eg env vars to pass on
  • still allowing repo sepcific setup
  • AWS_ENDPOINT_URL allows for injection for eg localstacl

notes

  • not fully clear how the full harness structure works, esp regarding variable inheritance/overrides.
  • likely we can move the two prefixed vars to the top of the makefile
  • there is already a terraform_version var with a predefined value in the test/terraform section, that one is different from the default in the test/src (in the calling repo), hence opted for a new var.

@hans-d hans-d requested a review from a team as a code owner March 8, 2024 22:59
@hans-d hans-d requested a review from Nuru March 8, 2024 22:59
@hans-d hans-d closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant