[metrics.Map] Use generics to implement Map #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map implementation is complex and expensive primarily to deal with both int64 and float64 values. Map is used almost always as a counter (e.g. resp-code, validation failure map), except for external probe output parsing where we can encounter a float map. To simplify Map implementation, split it into two implementations: Map (for int64 counters) and MapFloat (for any float64 values map).
… cloning performance. * Improve cloning performance by 33% by pre-allocating the map: - BenchmarkMapClone 908 1207415 ns/op 2053905 B/op 6413 allocs/op + BenchmarkMapClone 1305 840008 ns/op 1375780 B/op 4152 allocs/op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.