[probes.external] Parse stdout as soon as it is available. #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Log stderr as soon as it's read instead putting it in a channel. - Don't rely on timeout for testing. That makes it unreliable on CI. - Reduce external probe process runs for the TestProbeOnceMode test.
Change in #547 appears wrong as it was causing wait to be called on only for non-windows platforms, while issue was on windows. It seems that the issue was temporary and fixed by itself.
manugarg
force-pushed
the
external_streaming
branch
from
0459bb0
to
2b4ccb1
Compare
manugarg
changed the title
|
Fixes #691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.