Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[probes.external] Parse stdout as soon as it is available. #708

Merged
merged 3 commits into from
Apr 2, 2024
Merged

[probes.external] Parse stdout as soon as it is available. #708

merged 3 commits into from
Apr 2, 2024

Commits on Mar 30, 2024

  1. [probes.external] Read and parse stdout as soon as it is available.

    @manugarg
    manugarg committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    0ad754a View commit details
    Browse the repository at this point in the history

  2. [probes.external] Simplify streaming setup and improve tests. 

    - Log stderr as soon as it's read instead putting it in a channel.
- Don't rely on timeout for testing. That makes it unreliable on CI.
- Reduce external probe process runs for the TestProbeOnceMode test.
    @manugarg
    manugarg committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    ba5fab2 View commit details
    Browse the repository at this point in the history

  3. [probes.external] Tests: Remove wait for the command exit. 

    Change in #547 appears wrong as it was causing wait to be called on
only for non-windows platforms, while issue was on windows. It seems
that the issue was temporary and fixed by itself.
    @manugarg
    manugarg committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    2b4ccb1 View commit details
    Browse the repository at this point in the history