-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor wait-for-required-workflows
#9929
Comments
Thanks for opening the issue @candiduslynx. The changes described in this issue makes sense to me, and they are low risk and should be fast to implement, specifically:
As for #9655, the bulk of that change (and the risky part) is described in #9655 (comment). While the refactoring can help with making that change, I'm not sure it will reduce the risk or complexity of it. Regardless we don't need to couple those and can still do the refactoring, WDYT? |
@erezrokah your summary is on point. |
…#10072) Part of #9929 Inspired by https://github.com/marketplace/actions/github-script#run-a-separate-file-with-an-async-function The code is moved to a couple of separate js files & steps: 1. Define the required actions 2. Perform actual waiting Tested #10120
Closing given low priority. if ever becomes a high priority we will re-open. |
Which problem is this feature request solving?
I think the
wait-for-required-workflows
script might require an overhaul to accommodate for #9655.I wonder if we could move the script for wait from the workflow to the separate file (easier diff, dev): https://github.com/marketplace/actions/github-script#run-a-separate-file
Additionally, I think we could benefit from splitting the logic of the wait script into distinct parts (this can be doe either together with moving the code to separate file(s) or by splitting script step into several):
Describe the solution you'd like
skip-is-ok
logic for reused steps as this allows not to use runner at all and thus, save some CPU cycles/money, tooPull request (optional)
The text was updated successfully, but these errors were encountered: