Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oracle)!: Add region & availability_domain to primary keys #11042

Merged
merged 5 commits into from
Jun 5, 2023
Merged

fix(oracle)!: Add region & availability_domain to primary keys #11042

merged 5 commits into from
Jun 5, 2023

Conversation

candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented May 26, 2023 •
edited
Loading

Refactor as a follow-up to #11037

BEGIN_COMMIT_OVERRIDE
fix(oracle)!: Add region & availability_domain to primary keys(#11042)
BREAKING-CHANGE: The following primary key columns were added:

  • oracle_filestorage_export_sets: availability_domain
  • oracle_filestorage_file_systems: availability_domain
  • oracle_filestorage_mount_targets: availability_domain
  • oracle_filestorage_replication_targets: availability_domain
  • oracle_filestorage_replications: availability_domain
  • oracle_identity_compartments: region
  • oracle_identity_cost_tracking_tags: region
  • oracle_identity_dynamic_groups: region
  • oracle_identity_groups: region
  • oracle_identity_network_sources: region
  • oracle_identity_users: region

END_COMMIT_OVERRIDE

@candiduslynx candiduslynx requested a review from a team as a code owner May 26, 2023 16:32
@candiduslynx candiduslynx requested review from hermanschaaf and removed request for a team May 26, 2023 16:32
@github-actions
Copy link

github-actions bot commented May 26, 2023 •
edited
Loading

This PR has the following changes to source plugin(s) tables:

  • Table oracle_blockstorage_boot_volume_backups: column order changed for id
  • Table oracle_blockstorage_boot_volume_replicas: column order changed for id
  • Table oracle_blockstorage_boot_volumes: column order changed for id
  • Table oracle_blockstorage_volume_backup_policies: column order changed for id
  • Table oracle_blockstorage_volume_backups: column order changed for id
  • Table oracle_blockstorage_volume_group_backups: column order changed for id
  • Table oracle_blockstorage_volume_groups: column order changed for id
  • Table oracle_blockstorage_volumes: column order changed for id
  • Table oracle_compute_console_histories: column order changed for id
  • Table oracle_compute_dedicated_vm_hosts: column order changed for id
  • Table oracle_compute_images: column order changed for id
  • Table oracle_compute_instance_console_connections: column order changed for id
  • Table oracle_compute_instances: column order changed for id
  • Table oracle_compute_vnic_attachments: column order changed for id
  • Table oracle_database_external_container_databases: column order changed for id
  • Table oracle_database_external_non_container_databases: column order changed for id
  • Table oracle_database_external_pluggable_databases: column order changed for id
  • ⚠️ BREAKING CHANGE: Table oracle_filestorage_export_sets: primary key constraint added to column availability_domain
  • Table oracle_filestorage_export_sets: column order changed for id
  • Table oracle_filestorage_export_sets: column order changed for vcn_id
  • Table oracle_filestorage_exports: column order changed for id
  • ⚠️ BREAKING CHANGE: Table oracle_filestorage_file_systems: primary key constraint added to column availability_domain
  • Table oracle_filestorage_file_systems: column order changed for id
  • ⚠️ BREAKING CHANGE: Table oracle_filestorage_mount_targets: primary key constraint added to column availability_domain
  • Table oracle_filestorage_mount_targets: column order changed for id
  • ⚠️ BREAKING CHANGE: Table oracle_filestorage_replication_targets: primary key constraint added to column availability_domain
  • ⚠️ BREAKING CHANGE: Table oracle_filestorage_replications: primary key constraint added to column availability_domain
  • ⚠️ BREAKING CHANGE: Table oracle_identity_compartments: column added with name region (PK) and type utf8
  • ⚠️ BREAKING CHANGE: Table oracle_identity_cost_tracking_tags: column added with name region (PK) and type utf8
  • Table oracle_identity_cost_tracking_tags: column order changed for id
  • ⚠️ BREAKING CHANGE: Table oracle_identity_dynamic_groups: column added with name region (PK) and type utf8
  • ⚠️ BREAKING CHANGE: Table oracle_identity_groups: column added with name region (PK) and type utf8
  • ⚠️ BREAKING CHANGE: Table oracle_identity_network_sources: column added with name region (PK) and type utf8
  • ⚠️ BREAKING CHANGE: Table oracle_identity_users: column added with name region (PK) and type utf8
  • Table oracle_networkfirewall_work_requests: column order changed for id
  • Table oracle_networkloadbalancer_work_requests: column order changed for id
  • Table oracle_objectstorage_work_requests: column order changed for id
  • Table oracle_virtualnetwork_byoip_ranges: column order changed for id
  • Table oracle_virtualnetwork_cross_connect_groups: column order changed for id
  • Table oracle_virtualnetwork_cross_connects: column order changed for id
  • Table oracle_virtualnetwork_drg_attachments: column order changed for id
  • Table oracle_virtualnetwork_ip_sec_connections: column order changed for id
  • Table oracle_virtualnetwork_local_peering_gateways: column order changed for id
  • Table oracle_virtualnetwork_public_ip_pools: column order changed for id
  • Table oracle_virtualnetwork_remote_peering_connections: column order changed for id
  • Table oracle_virtualnetwork_security_lists: column order changed for id
  • Table oracle_virtualnetwork_service_gateways: column order changed for id
  • Table oracle_virtualnetwork_subnets: column order changed for id
  • Table oracle_virtualnetwork_vcns: column order changed for id
  • Table oracle_virtualnetwork_virtual_circuits: column order changed for id
  • Table oracle_virtualnetwork_vlans: column order changed for id
  • Table oracle_virtualnetwork_vtaps: column order changed for id

@candiduslynx candiduslynx changed the title fix(oracle): Primary keys fix(oracle)!: Primary keys May 26, 2023
@candiduslynx candiduslynx changed the title fix(oracle)!: Primary keys fix(oracle)!: Add region & compartment_id to primary keys May 26, 2023
@candiduslynx candiduslynx added automerge Automatically merge once required checks pass and removed automerge Automatically merge once required checks pass labels May 26, 2023
@candiduslynx candiduslynx changed the title fix(oracle)!: Add region & compartment_id to primary keys fix(oracle)!: Primary keys May 26, 2023
@candiduslynx candiduslynx changed the title fix(oracle)!: Primary keys fix(oracle)!: Add region, compartment_id & availability_domain to primary keys May 26, 2023
@candiduslynx candiduslynx changed the title fix(oracle)!: Add region, compartment_id & availability_domain to primary keys fix(oracle)!: Add region & availability_domain to primary keys May 26, 2023
@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label May 26, 2023
yevgenypats
yevgenypats requested changes May 26, 2023
View reviewed changes
Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving (but putting on reject so it wont get merged until next week). Given it's a big change with more breaking I suggest pushing it after the next release so we at least can know if something broke in this huge PR or in the previous one.

@kodiakhq kodiakhq bot merged commit ee2b208 into main Jun 5, 2023
15 checks passed
@kodiakhq kodiakhq bot deleted the fix/oracle/refactor branch June 5, 2023 13:19
@cq-bot cq-bot mentioned this pull request Jun 5, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 6, 2023
@cq-bot
chore(main): Release plugins-source-oracle v3.0.0 (#11139)
d67cb44 
🤖 I have created a release *beep* *boop*
---


## [3.0.0](plugins-source-oracle-v2.0.0...plugins-source-oracle-v3.0.0) (2023-06-06)


### ⚠ BREAKING CHANGES

* **oracle:** The following primary key columns were added:
    * `oracle_filestorage_export_sets`: `availability_domain`
    * `oracle_filestorage_file_systems`: `availability_domain`
    * `oracle_filestorage_mount_targets`: `availability_domain`
    * `oracle_filestorage_replication_targets`: `availability_domain`
    * `oracle_filestorage_replications`: `availability_domain`
    * `oracle_identity_compartments`: `region`
    * `oracle_identity_cost_tracking_tags`: `region`
    * `oracle_identity_dynamic_groups`: `region`
    * `oracle_identity_groups`: `region`
    * `oracle_identity_network_sources`: `region`
    * `oracle_identity_users`: `region`

### Bug Fixes

* **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 20b0de9 ([#11199](#11199)) ([dc3565d](dc3565d))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 88d5dc2 ([#11226](#11226)) ([9f306bc](9f306bc))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to a7aad4c ([#11184](#11184)) ([8a0822e](8a0822e))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#11169](#11169)) ([dcb0f92](dcb0f92))
* **deps:** Update golang.org/x/exp digest to 2e198f4 ([#11155](#11155)) ([c46c62b](c46c62b))
* **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.9 ([#11240](#11240)) ([f92cd4b](f92cd4b))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.3 ([#11150](#11150)) ([dc00994](dc00994))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.4 ([#11244](#11244)) ([8fceef6](8fceef6))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.7.0 ([#11113](#11113)) ([487bf87](487bf87))
* **oracle:** Add `region` & `availability_domain` to primary keys([#11042](#11042)) ([ee2b208](ee2b208))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevgenypats yevgenypats yevgenypats approved these changes

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf hermanschaaf was automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@candiduslynx @yevgenypats @cq-bot