-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: List tables from ALL_TABLES
with TABLESPACE_NAME = 'USERS'
#11163
Merged
kodiakhq
merged 4 commits into
cloudquery:main
from
erezrokah:fix/oracledb_source_list_tables
Jun 5, 2023
Merged
fix: List tables from ALL_TABLES
with TABLESPACE_NAME = 'USERS'
#11163
kodiakhq
merged 4 commits into
cloudquery:main
from
erezrokah:fix/oracledb_source_list_tables
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
approved these changes
Jun 1, 2023
215c718
to
f3c8a3b
Compare
I moved this to draft per #10964 (comment) |
ALL_TAB_COLS
instead of USER_TAB_COLS
ALL_TABLES
with TABLESPACE_NAME = 'USERS'
candiduslynx
approved these changes
Jun 5, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.0](plugins-source-oracledb-v1.1.1...plugins-source-oracledb-v1.2.0) (2023-06-06) ### Features * **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 20b0de9 ([#11199](#11199)) ([dc3565d](dc3565d)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 88d5dc2 ([#11226](#11226)) ([9f306bc](9f306bc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to a7aad4c ([#11184](#11184)) ([8a0822e](8a0822e)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#11169](#11169)) ([dcb0f92](dcb0f92)) * **deps:** Update golang.org/x/exp digest to 2e198f4 ([#11155](#11155)) ([c46c62b](c46c62b)) * **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.9 ([#11240](#11240)) ([f92cd4b](f92cd4b)) * List tables from `ALL_TABLES` with `TABLESPACE_NAME = 'USERS'` ([#11163](#11163)) ([865639b](865639b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…11526) #### Summary Follow up to #11163. Hopefully fixes #10964 (comment) See https://www.oracletutorial.com/oracle-administration/oracle-tablespace/: ![image](https://github.com/cloudquery/cloudquery/assets/26760571/e1632e41-6711-4409-9971-7a2a341afd56) If this causes issue the other option is to allow uses to configure it. <!--
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10964
See explanation in #10964 (comment)