fix(race): Fix race in DuckDB delete-stale #11215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
force-pushed
the
fix/duckdb/delete-write-race
branch
from
7dc210d
to
7c3c8b6
Compare
candiduslynx
requested review from
bbernays,
hermanschaaf and
yevgenypats
and removed request for
a team
disq
reviewed
Jun 5, 2023
hermanschaaf
reviewed
Jun 5, 2023
Co-authored-by: Kemal <223029+disq@users.noreply.github.com>
hermanschaaf
reviewed
Jun 5, 2023
| // per https://duckdb.org/docs/sql/indexes#over-eager-unique-constraint-checking we might need to retry | ||
| return backoff.Retry( | ||
| func() error { | ||
| return c.exec(ctx, "insert into "+table.Name+" from "+tmpTableName) |
There was a problem hiding this comment.
is there any way we can detect the unique constraint violation error and only retry that, rather than retrying all errors?
There was a problem hiding this comment.
We could detect it only via comparing error strings, but I'd rather leave it to the further implementation if we ever need to touch this place once again.
I hope that the issue is fixed by DuckDB itself thus making this code obsolete and enabling us to remove this backoff sooner though.
hermanschaaf
approved these changes
Jun 5, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-destination-duckdb-v3.0.0...plugins-destination-duckdb-v4.0.0) (2023-06-06) ### ⚠ BREAKING CHANGES * **types:** Support writing Apache Arrow nested types: * Structs as DuckDB structs * Maps as DuckDB maps ### Features * **types:** Proper support for nested types ([#11196](#11196)) ([7c6a3e2](7c6a3e2)) ### Bug Fixes * **deps:** Update `github.com/cloudquery/plugin-sdk/v3` to `v3.10.0` ([#11116](#11116)) ([bba7c4e](bba7c4e)) * **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 88d5dc2 ([#11226](#11226)) ([9f306bc](9f306bc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to a7aad4c ([#11184](#11184)) ([8a0822e](8a0822e)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#11169](#11169)) ([dcb0f92](dcb0f92)) * **deps:** Update golang.org/x/exp digest to 2e198f4 ([#11155](#11155)) ([c46c62b](c46c62b)) * **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.9 ([#11240](#11240)) ([f92cd4b](f92cd4b)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.3 ([#11150](#11150)) ([dc00994](dc00994)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.4 ([#11244](#11244)) ([8fceef6](8fceef6)) * **race:** Fix issue caused by [Over-Eager Unique Constraint Checking](https://duckdb.org/docs/sql/indexes#over-eager-unique-constraint-checking) in DuckDB overwrite ([#11215](#11215)) ([c0b9f0a](c0b9f0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix(race): Fix issue caused by Over-Eager Unique Constraint Checking in DuckDB overwrite (#11215)
END_COMMIT_OVERRIDE