Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): Consumption legacy usage details #11242

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

disq
Copy link
Member

@disq disq commented Jun 6, 2023

Fixes https://github.com/cloudquery/cloudquery-issues/issues/565

This fix ignores all returned types except LegacyUsageDetail from the API call (which can sometimes include ModernUsageDetail for some undocumented reason, to our understanding) but since we have another resource listing those (azure_consumption_billing_account_modern_usage_details) we don't want them here.

// UsageDetailClassification provides polymorphic access to related types.
// Call the interface's GetUsageDetail() method to access the common type.
// Use a type switch to determine the concrete type.  The possible types are:
// - *LegacyUsageDetail, *ModernUsageDetail, *UsageDetail
type UsageDetailClassification interface {
	// GetUsageDetail returns the UsageDetail content of the underlying type.
	GetUsageDetail() *UsageDetail
}

@cq-bot cq-bot removed the website label Jun 6, 2023
@cloudquery cloudquery deleted a comment from github-actions bot Jun 6, 2023
@disq disq added the automerge Automatically merge once required checks pass label Jun 6, 2023
@kodiakhq kodiakhq bot merged commit 8da78c6 into cloudquery:main Jun 6, 2023
11 checks passed
kodiakhq bot pushed a commit that referenced this pull request Jun 6, 2023
🤖 I have created a release *beep* *boop*
---


## [8.1.0](plugins-source-azure-v8.0.0...plugins-source-azure-v8.1.0) (2023-06-06)


### Features

* **azure-resources:** Add DNS Record Sets ([#10918](#10918)) ([7c56926](7c56926))
* **azure:** Add CIS 1.21, 6.3, 6.4, 8.5 policies ([#11194](#11194)) ([a3cda9b](a3cda9b))
* **azure:** Implement missing CIS policies ([#10928](#10928)) ([3ae3df3](3ae3df3))


### Bug Fixes

* **azure:** Consumption legacy usage details ([#11242](#11242)) ([8da78c6](8da78c6))
* **azure:** Fix some CIS Azure policies ([#11228](#11228)) ([b95a4df](b95a4df))
* **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 20b0de9 ([#11199](#11199)) ([dc3565d](dc3565d))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 88d5dc2 ([#11226](#11226)) ([9f306bc](9f306bc))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to a7aad4c ([#11184](#11184)) ([8a0822e](8a0822e))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#11169](#11169)) ([dcb0f92](dcb0f92))
* **deps:** Update golang.org/x/exp digest to 2e198f4 ([#11155](#11155)) ([c46c62b](c46c62b))
* **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.9 ([#11240](#11240)) ([f92cd4b](f92cd4b))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.3 ([#11150](#11150)) ([dc00994](dc00994))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.4 ([#11244](#11244)) ([8fceef6](8fceef6))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.7.0 ([#11113](#11113)) ([487bf87](487bf87))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@disq disq deleted the fix/azure-usagedetail branch June 7, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants