Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add more details to the guide on publishing plugins #15753

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

pilvikala
Copy link
Contributor

Summary

Adding a bit more detail to the guide on publishing plugins - what the team name/display name is, and how to use the plugin visibility and release stage for staging plugin releases.

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change 🚀 Added a few comments.

Also can we keep the file as .md. Not sure why we need .mdx. .md supports HTML too


<img src="/images/docs/publishing-plugins/create-team.png" width="50%" style={{margin:"1em"}} />

The display name will be visible on Hub next to your plugin. The team name is going to be used in configs to reference your plugin using `team-name/plugin-name`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The display name will be visible on Hub next to your plugin. The team name is going to be used in configs to reference your plugin using `team-name/plugin-name`.
The display name will be visible on Hub next to your plugin. The team name is going to be used in configurations to reference your plugin using `<team-name>/<plugin-name>`.

We often use <> to denote a value the user should replace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

5. Once you're ready run `cloudquery plugin publish -f` to publish a non draft version of the plugin. This version will be immutable and will show up in <https://hub.cloudquery.io/>. Allow up to 1 hour for the Hub to reflect the changes
1. (Optional, recommended) In the root directory of your plugin repository run `git tag v1.0.0` to tag the version you're about to publish (replace `v1.0.0` with the version you'd like to publish).
2. (Optional, recommended) Run `git push origin v1.0.0` to push the tag.
3. Run `go run main.go package --docs-dir docs -m 'feat: Initial release' v1.0.0 .` to package the plugin. `v1.0.0` should match the tag you created in step 1. The `-m` specifies the changelog message that will be used in the release notes and it supports markdown. See example [here](https://hub.cloudquery.io/plugins/.source/cloudquery/alicloud/v4.0.14/versions). `docs` should be a directory containing markdown files that serve as documentation for the plugin. Read more about the documentation format [here](#documentation-format).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Run `go run main.go package --docs-dir docs -m 'feat: Initial release' v1.0.0 .` to package the plugin. `v1.0.0` should match the tag you created in step 1. The `-m` specifies the changelog message that will be used in the release notes and it supports markdown. See example [here](https://hub.cloudquery.io/plugins/.source/cloudquery/alicloud/v4.0.14/versions). `docs` should be a directory containing markdown files that serve as documentation for the plugin. Read more about the documentation format [here](#documentation-format).
3. Run `go run main.go package --docs-dir docs -m 'feat: Initial release' v1.0.0 .` to package the plugin. `v1.0.0` should match the tag you created in step 1. The `-m` specifies the changelog message that will be used in the release notes and it supports markdown. See example [here](https://hub.cloudquery.io/plugins/source/cloudquery/alicloud/v4.0.14/versions). `docs` should be a directory containing markdown files that serve as documentation for the plugin. Read more about the documentation format [here](#documentation-format).

I believe this dot breaks the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

1. (Optional, recommended) In the root directory of your plugin repository run `git tag v1.0.0` to tag the version you're about to publish (replace `v1.0.0` with the version you'd like to publish).
2. (Optional, recommended) Run `git push origin v1.0.0` to push the tag.
3. Run `go run main.go package --docs-dir docs -m 'feat: Initial release' v1.0.0 .` to package the plugin. `v1.0.0` should match the tag you created in step 1. The `-m` specifies the changelog message that will be used in the release notes and it supports markdown. See example [here](https://hub.cloudquery.io/plugins/.source/cloudquery/alicloud/v4.0.14/versions). `docs` should be a directory containing markdown files that serve as documentation for the plugin. Read more about the documentation format [here](#documentation-format).
4. Run `cloudquery plugin publish` to publish a draft version of the plugin. The version will show up under the versions tab of your plugin in (https://cloud.cloudquery.io). As long as the version is in draft it's mutable and you can re-package the plugin and publish it again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Run `cloudquery plugin publish` to publish a draft version of the plugin. The version will show up under the versions tab of your plugin in (https://cloud.cloudquery.io). As long as the version is in draft it's mutable and you can re-package the plugin and publish it again.
4. Run `cloudquery plugin publish` to publish a draft version of the plugin. The version will show up under the versions tab of your plugin in <https://cloud.cloudquery.io>. As long as the version is in draft it's mutable and you can re-package the plugin and publish it again.

For bare URLs we should use <> otherwise they look like this:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed so it's not bare

@pilvikala
Copy link
Contributor Author

Great change 🚀 Added a few comments.

Also can we keep the file as .md. Not sure why we need .mdx. .md supports HTML too

How do I add the HTML to markdown? The html <img> does not get rendered when the file is .md.

Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
@disq disq removed the needs-area label Dec 20, 2023
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Dec 21, 2023
@kodiakhq kodiakhq bot merged commit 83b0cef into main Dec 21, 2023
13 checks passed
@kodiakhq kodiakhq bot deleted the doc-publishing-plugins branch December 21, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website automerge Automatically merge once required checks pass kind/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants