Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add intergrations redirects #16681

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Conversation

jackcloudquery
Copy link
Contributor

@jackcloudquery jackcloudquery commented Feb 17, 2024

Summary

⚠️ If you're contributing to a plugin please read this section of the contribution guidelines 🧑‍🎓 before submitting this PR ⚠️

Add redirects for the integrations pages

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run make lint to ensure the proposed changes follow the coding style 🚨 (install golangci-lint here)
  • Run make test to ensure the proposed changes pass the tests 🧪
  • If changing a source plugin run make gen to ensure docs are up to date 📝
  • Ensure the status checks below are successful ✅

@jackcloudquery jackcloudquery changed the title Add intergrations redirects chore: add intergrations redirects Feb 17, 2024
@jackcloudquery jackcloudquery changed the title chore: add intergrations redirects chore: Add intergrations redirects Feb 17, 2024
@jackcloudquery jackcloudquery merged commit 1d11bb9 into main Feb 18, 2024
29 checks passed
@jackcloudquery jackcloudquery deleted the feat/integrations-redirect branch February 18, 2024 05:33
kodiakhq bot pushed a commit that referenced this pull request May 14, 2024
#### Summary

Not sure why the Website build didn't fail in #17903, but it fails on `main`:

```
Error: No _configuration.md file found for source: firestore
--
15:37:38.719 | at <anonymous> (/vercel/path0/website/scripts/prebuild.tsx:166:17)
```

We shouldn't generate integration pages at all and redirect per #16681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants