chore: Remove old integration pages #17958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
May 14, 2024
| @@ -86,7 +86,7 @@ export const ALL_PLUGINS: Plugin[] = [ | |||
| logoDark: "/images/logos/plugins/firestore-dark.svg", | |||
| id: "firestore", | |||
| kind: "source", | |||
| availability: "free", | |||
| availability: "premium", | |||
There was a problem hiding this comment.
There's more cleanup to be done to remove any plugin data from the old Website, but didn't want to dig too deep into it
erezrokah
commented
May 14, 2024
| @@ -870,114 +870,6 @@ | |||
| "source": "/docs/plugins/destinations/sqlite/:path*", | |||
| "destination": "https://hub.cloudquery.io/plugins/destination/cloudquery/sqlite" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
We have to remove the existing redirects otherwise https://github.com/cloudquery/cloudquery/pull/16681/files#diff-21378a71578c160a16aa86a2ccc6120c09d1d10a3deaf16af651a228bd0cfde4R1054 won't match
erezrokah
force-pushed
the
chore/remove_old_integrations
branch
from
7011a2e
to
41ffbfa
Compare
erezrokah
requested review from
hermanschaaf and
jackcloudquery
and removed request for
maaarcelino
erezrokah
force-pushed
the
chore/remove_old_integrations
branch
from
41ffbfa
to
9a3716f
Compare
jackcloudquery
approved these changes
May 14, 2024
erezrokah
force-pushed
the
chore/remove_old_integrations
branch
from
9a3716f
to
7508e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Not sure why the Website build didn't fail in #17903, but it fails on
main:We shouldn't generate integration pages at all and redirect per #16681