-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add local sync summary #17112
feat: Add local sync summary #17112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I believe this closes #8690
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's schedule another meeting on that to discuss the use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, had a few questions/comments
🤖 I have created a release *beep* *boop* --- ## [5.13.0](cli-v5.12.1...cli-v5.13.0) (2024-04-02) ### Features * Add local sync summary ([#17112](#17112)) ([d98f544](d98f544)) ### Bug Fixes * **deps:** Update golang.org/x/exp digest to a685a6e ([#17429](#17429)) ([093bc86](093bc86)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.13 ([#17444](#17444)) ([da276fe](da276fe)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.6 ([#17446](#17446)) ([cd73a0a](cd73a0a)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.7 ([#17447](#17447)) ([48665fb](48665fb)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.2 ([#17450](#17450)) ([2947506](2947506)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.3 ([#17456](#17456)) ([020865a](020865a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Summary
This pr adds in a sync summary that gets outputted to a user defined location. If the user doesn't define the location via the cli flag then the summary will not be persisted.
The file is a .jsonl format