-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Rename domains c_name
to cname
#2635
fix!: Rename domains c_name
to cname
#2635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing gen-code, otherwise LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for doing the refactoring work as well 👍
@hermanschaaf looks like another breaking change due to https://github.com/cloudquery/cloudquery/pull/2635/files#diff-f8e4debb63fb716d5f8829d87f8dbdc19564da7bc53b4d3481d6cade51593fab: |
c_name
to cname
🤖 I have created a release *beep* *boop* --- ## [2.0.0](plugins-source-heroku-v1.0.1...plugins-source-heroku-v2.0.0) (2022-10-12) ### ⚠ BREAKING CHANGES * Rename domains `c_name` to `cname` (#2635) ### Bug Fixes * **deps:** Update plugin-sdk for heroku to v0.12.10 ([#2551](#2551)) ([d0771ec](d0771ec)) * Rename domains `c_name` to `cname` ([#2635](#2635)) ([70ff2dc](70ff2dc)) * Upgrade source SDK versions to v0.13.5 ([#2610](#2610)) ([611868e](611868e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: shimonp21 <37939765+shimonp21@users.noreply.github.com>
Summary
Related to #2189.
../resources/services
for consistency with other plugins (there's a follow up here to put each namespace in a separate directory, but didn't want to do too many changes)plugin/plugin.go
toresources/plugin/plugin.go
. This is required so Go Releaser embeds the correct version of the plugin during release, seecloudquery/plugins/.goreleaser.yaml
Line 12 in 6ab0429