Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

feat(resolvers): Remove column level IgnoreError #326

Closed
erezrokah opened this issue Jun 7, 2022 · 1 comment
Closed

feat(resolvers): Remove column level IgnoreError #326

erezrokah opened this issue Jun 7, 2022 · 1 comment
Assignees

Comments

@erezrokah
Copy link
Member

SDK consumers can defined IgnoreError handlers per tables and per columns.

The column level functionality seems to be used in a single resource in the GCP provider https://github.com/cloudquery/cq-provider-gcp/blob/8db6d1e043aec6b17f1f30afc3a0cb551595e34e/resources/services/kubernetes/clusters.go#L145

As this feature is not properly documented (only in our code) and barely used we should remove it from the SDK, and change the GCP provider to add a custom resolver for IP addresses that ignores the relevant errors.

@erezrokah
Copy link
Member Author

Done in #323

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant