This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
feat!: IgnoreError Recursively for tables and columns #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
requested review from
bbernays and
disq
and removed request for
a team
erezrokah
reviewed
Jun 7, 2022
yevgenypats
force-pushed
the
feat/ignore_error_recursively
branch
from
be46ca5
to
4c262a6
Compare
disq
reviewed
Jun 7, 2022
erezrokah
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
🚀 @yevgenypats please squash merge with a commit title prefix of feat!: as this is a breaking change
|
@erezrokah will do! Will wait on @disq approval (regarding comment) and will squash merge 🚀 |
yevgenypats
changed the title
yevgenypats
force-pushed
the
feat/ignore_error_recursively
branch
2 times, most recently
from
50a47be
to
8622c31
Compare
yevgenypats
force-pushed
the
feat/ignore_error_recursively
branch
from
8622c31
to
a2b1816
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉
Summary
This adds recursive logic for both columns and tables so we dont have to put it in every column and relation.
This need more tests but ready for initial review.
Closes #323
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)