fix: Support list scalars from JSON #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
requested review from
yevgenypats,
hermanschaaf and
erezrokah
as code owners
⏱️ Benchmark results
|
|
Could you also verify that the same fix is present in other SDKs? |
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Feb 21, 2024
This makes it fully sync the testdata table from the test source plugin (with [fixed](cloudquery/plugin-sdk#1530) list scalars...) using parquet loading. Also removes `interval` references which didn't work in parquet anyway.
Opened issues, linked above (Java SDK doesn't support lists at all so added a general issue for that too) |
erezrokah
approved these changes
Feb 22, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
🤖 I have created a release *beep* *boop* --- ## [4.31.0](v4.30.0...v4.31.0) (2024-02-27) ### Features * Allow homogeneous data types to be configured ([#1533](#1533)) ([ca7cdb8](ca7cdb8)) ### Bug Fixes * Default Plugin logger assumes plugin is a `source` ([#1531](#1531)) ([b7dcd56](b7dcd56)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.18.0 ([#1528](#1528)) ([4cc6ade](4cc6ade)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.0 ([#1532](#1532)) ([4b475bb](4b475bb)) * Support list scalars from JSON ([#1530](#1530)) ([cf13dd5](cf13dd5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, lists from the test source (at least, could be more plugins/cases) get persisted as
[]I'm still not 100% sure how the lists end up getting encoded to JSON, probably we use Arrow's
.ValueStrand/or.GetOneForMarshalsomewhere.Called from table resolver - source plugins need this fix.