feat: Implement transformations logic. #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark results
|
marianogappa
commented
Jul 18, 2024
erezrokah
reviewed
Jul 18, 2024
|
I replaced this sdk version onto the monorepo and added preliminary support for transformers in syncs, and I added a "reverser" transformer. Here's the result of hooking it up on an xkcd sync:
|
erezrokah
approved these changes
Jul 19, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
🤖 I have created a release *beep* *boop* --- ## [4.50.0](v4.49.4...v4.50.0) (2024-07-19) ### Features * Implement transformations logic. ([#1800](#1800)) ([377194e](377194e)) ### Bug Fixes * Use trace level for source batcher log message ([#1803](#1803)) ([6ccf7e6](6ccf7e6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of sdk changes to add transformations support, so that transformer plugins can be created.
I don't want to merge it yet, because the channel logic is not well thought out. I'd rather want to do a test sync locally with some transformation.