local缩略图功能提升 #1044
Merged
local缩略图功能提升 #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "github.com/nfnt/resize" with "golang.org/x/image/draw". Add thumb task queue to avoid oom when batch thumb operation
HFO4
reviewed
Nov 8, 2021
| func (pool *Pool) releaseWorker() { | ||
| util.Log().Debug("Thumb任务队列，releaseWorker") | ||
| <-pool.worker | ||
| } |
There was a problem hiding this comment.
Do we have any Unit Tests for this?
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"github.com/nfnt/resize"换成 "golang.org/x/image/draw"，因为前者已经不维护了。
修复当批量重新生成本地缩略图时，oom崩溃——添加了并发限制，默认为cpu核心数，可配置
添加了local缩略图生成后强制GC，添加配置项，默认false
local缩略图可配置编码方式，默认jpg并设置85。
MaxTaskCount: -1,
EncodeMethod: "jpg",
GCAfterGen: false,
EncodeQuality: 85,