Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change TS compilation target to es2019 (#144)" #169

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Aug 17, 2022

This reverts commit a068119 as causing issues in the internal pipeline.

Description

[Include a summary of the changes and the related issue.]

[Also include relevant motivation and context.]

How has this been tested?

[How did you test to verify your changes?]

[How can reviewers test these changes efficiently?]

[Check for unexpected visual regressions, see CONTRIBUTING.md for details.]

Documentation changes

[Do the changes include any API documentation changes?]

  • Yes, this change contains documentation changes.
  • No.

Related Links

[Attach any related links/pull request for this change]

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot marked this pull request as ready for review August 17, 2022 09:39
@pan-kot pan-kot requested a review from a team as a code owner August 17, 2022 09:39
@pan-kot pan-kot requested review from gethinwebster and removed request for a team August 17, 2022 09:39
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #169 (4733786) into main (c4f788e) will increase coverage by 1.82%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   90.59%   92.42%   +1.82%     
==========================================
  Files         537      537              
  Lines       13269    15520    +2251     
  Branches     4254     4259       +5     
==========================================
+ Hits        12021    14344    +2323     
+ Misses       1166     1094      -72     
  Partials       82       82              
Impacted Files Coverage Δ
src/tag-editor/index.tsx 90.72% <0.00%> (+0.61%) ⬆️
src/tag-editor/utils.ts 65.00% <0.00%> (-21.67%) ⬇️
src/mixed-line-bar-chart/utils.ts 92.15% <100.00%> (+0.49%) ⬆️
src/top-navigation/parts/overflow-menu/header.tsx 7.14% <0.00%> (-5.36%) ⬇️
...p-navigation/parts/overflow-menu/views/submenu.tsx 5.88% <0.00%> (-4.12%) ⬇️
src/select/parts/virtual-list.tsx 8.33% <0.00%> (-3.21%) ⬇️
src/top-navigation/parts/overflow-menu/index.tsx 5.55% <0.00%> (-1.59%) ⬇️
...navigation/parts/overflow-menu/views/utilities.tsx 11.11% <0.00%> (-1.39%) ⬇️
...c/top-navigation/parts/overflow-menu/menu-item.tsx 7.69% <0.00%> (-0.75%) ⬇️
src/s3-resource-selector/s3-modal/table-utils.ts 88.88% <0.00%> (-0.59%) ⬇️
... and 322 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants