Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for multiple projects in Firestore storage #213

Closed
nielm opened this issue Feb 22, 2024 · 0 comments · Fixed by #215, #239 or #266
Closed

No support for multiple projects in Firestore storage #213

nielm opened this issue Feb 22, 2024 · 0 comments · Fixed by #215, #239 or #266
Assignees
@nielm
Labels
bug Something isn't working javascript Pull requests that update Javascript code

Comments

@nielm
Copy link
Collaborator

nielm commented Feb 22, 2024

The docId for the state in the Firestore database only contains spanner instance ID:

this.firestore.collection('spannerAutoscaler').doc(this.instanceId);

Whereas the rowID for the state in the Spanner contains both project and instanceID:

projects/${this.projectId}/instances/${this.instanceId}

This effectively means that Firestore storage cannot support scaling Spanner instances in different projects with the same name...
@nielm nielm self-assigned this Feb 22, 2024
@nielm nielm added bug Something isn't working javascript Pull requests that update Javascript code labels Feb 22, 2024
nielm added a commit to nielm/autoscaler that referenced this issue Feb 23, 2024
@nielm
Migrate to using new docPath for Firestore including projectID
e30851b 
fixes cloudspannerecosystem#213
nielm added a commit to nielm/autoscaler that referenced this issue Feb 23, 2024
@nielm
Migrate to using new docPath for Firestore including projectID
2902d46 
fixes cloudspannerecosystem#213
@nielm nielm mentioned this issue Feb 23, 2024
Merged
nielm added a commit to nielm/autoscaler that referenced this issue Feb 23, 2024
@nielm
Migrate to using new docPath for Firestore including projectID
dad05d0 
fixes cloudspannerecosystem#213
nielm added a commit to nielm/autoscaler that referenced this issue Feb 23, 2024
@nielm
Migrate to using new docPath for Firestore including projectID
3801bf4 
fixes cloudspannerecosystem#213
nielm added a commit to nielm/autoscaler that referenced this issue Feb 23, 2024
@nielm
Migrate to using new docPath for Firestore including projectID
97d250e 
fixes cloudspannerecosystem#213
nielm added a commit to nielm/autoscaler that referenced this issue Feb 27, 2024
@nielm
Migrate to using new docPath for Firestore including projectID
f006991 
fixes cloudspannerecosystem#213
nielm added a commit to nielm/autoscaler that referenced this issue Feb 27, 2024
@nielm
Migrate to using new docPath for Firestore including projectID
a202b88 
fixes cloudspannerecosystem#213
nielm added a commit to nielm/autoscaler that referenced this issue Feb 27, 2024
@nielm
Migrate to using new docPath for Firestore including projectID
1910a88 
fixes cloudspannerecosystem#213
nielm added a commit to nielm/autoscaler that referenced this issue Mar 4, 2024
@nielm
Migrate to using new docPath for Firestore including projectID
fc66f85 
fixes cloudspannerecosystem#213
henrybell pushed a commit that referenced this issue Mar 5, 2024
@nielm
Migrate to using new docPath for Firestore including projectID (#215)
aa19f02 
fixes #213
nielm added a commit that referenced this issue Mar 12, 2024
@nielm
fix: Migrate to using new docPath for Firestore including projectID (#…
3d9771d 
…215)

fixes #213
This was referenced Mar 12, 2024
Closed
Merged
Closed
This was referenced Mar 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nielm nielm

Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
1 participant
@nielm