Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fine-grained ACL support #140

Conversation

apstndb
Copy link
Collaborator

@apstndb apstndb commented Sep 9, 2022

This PR adds fine-grained ACL related DDLs support(GRANT, REVOKE).

spanner> CREATE ROLE singers_reader;
Query OK, 0 rows affected (6.89 sec)

spanner> GRANT SELECT ON TABLE Singers TO ROLE singers_reader;
Query OK, 0 rows affected (6.49 sec)

spanner> REVOKE SELECT ON TABLE Singers FROM ROLE singers_reader;
Query OK, 0 rows affected (7.47 sec)

spanner> DROP ROLE singers_reader;
Query OK, 0 rows affected (6.52 sec)

close #139

@yfuruyama yfuruyama self-requested a review September 9, 2022 08:41
Copy link
Collaborator

@yfuruyama yfuruyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for implementing this!

Let me merge this PR once the feature is officially announced in the release note.

@yfuruyama
Copy link
Collaborator

The feature was released today: https://cloud.google.com/spanner/docs/release-notes#September_15_2022

@yfuruyama yfuruyama merged commit d65f4b6 into cloudspannerecosystem:master Sep 16, 2022
@apstndb apstndb deleted the feature/add-fine-grained-acl-ddls branch September 16, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DDL statements for fine-grained access control
2 participants