Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should interactive mode ask you about creating new stacks? #569

Open
ejholmes opened this issue Mar 16, 2018 · 3 comments
Open

Should interactive mode ask you about creating new stacks? #569

ejholmes opened this issue Mar 16, 2018 · 3 comments

Comments

@ejholmes
Copy link
Contributor

The current behavior of --interactive is that any new stacks will get created, without any prompt. But this can be potentially dangerous (or at the very least, annoying) if you accidentally make a change, like changing the stack name, resulting in a whole new stack getting created.

Should stacker prompt you before creating a stack when using --interactive mode?

@russellballestrini
Copy link
Member

My quick reaction is yes it should prompt before making any changes including creates.

@phobologic
Copy link
Member

I can see it either way. It definitely was a design decision to have it not bother you about creates (since they were deemed "safe") - only when it was actually making a change to an existing stack. I'd be fine with changing it though.

@acmcelwee
Copy link
Member

I'd vote yes, but now that starts to complicate #583, since the new stacks won't have a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants