Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong json created for AWS::Logs::Destination #481

Closed
drmaples opened this issue May 2, 2016 · 1 comment
Closed

wrong json created for AWS::Logs::Destination #481

drmaples opened this issue May 2, 2016 · 1 comment

Comments

@drmaples
Copy link

drmaples commented May 2, 2016

logs.Destination doesnt generate the correct json CloudFormation expects since its sublcassing the wrong thing. should be AWSObject instead of AWSProperty

attempting to create the stack throws this exception

botocore.exceptions.ClientError: An error occurred (ValidationError) when calling the CreateStack operation: Invalid template resource property 'DestinationName'

bad json output

"MyLogDestination": {
    "DestinationName": "destination-name",
    "DestinationPolicy": "destination-policy-arn",
    "RoleArn": "role-arn",
    "TargetArn": "target-arn",
    "Type": "AWS::Logs::Destination"
}

according to the docs, the output should look like this:

"MyLogDestination": {
    "Properties": {
        "DestinationName": "destination-name",
        "DestinationPolicy": "destination-policy-arn",
        "RoleArn": "role-arn",
        "TargetArn": "target-arn"
    },
    "Type": "AWS::Logs::Destination"
}
drmaples pushed a commit to drmaples/troposphere that referenced this issue May 2, 2016
- the output for destination should be nested under `Property`, using the correct base class achieves this.
- issue cloudtools#481
@markpeek
Copy link
Member

markpeek commented May 2, 2016

Thanks. I pushed a fix at about the same time you did. :-)

webratz pushed a commit to webratz/troposphere that referenced this issue May 4, 2016
* cloudtools/master: (80 commits)
  Add test for AWS::Logs::Destination (cloudtools#482)
  Fix baseclass for AWS::Logs::Destination (Fixes cloudtools#481)
  Update for changes since 1.5.0
  Fix Bucket AccessControl to allow Ref (cloudtools#475)
  Better AWSHelperFn support in template generator (cloudtools#473)
  Implement LifecycleRule Transitions property (cloudtools#472)
  Update to Apr 25, 2016 release (cloudtools#471)
  Fix Source object to take a list of SourceDetails (cloudtools#469)
  Update Contribute Document to Use Requirements.txt (cloudtools#470)
  Add WAF SizeConstraintSet and XssMatchSet
  Add backward compatibility for the deprecated ElasticsearchDomain
  Fix Elasticsarch Domain object naming
  Import JSON Templates (cloudtools#468)
  ReplicationConfigurationRules Destination is now an object (cloudtools#380)
  Remove unnecessary AWSHelperFn from props
  EC2 update FromPort, ToPort and Egress as optional
  Added CloudWatch Events support
  ApiGateway Resources (cloudtools#466)
  Provide Valid Lambda Function Memory Values for use in Parameters (cloudtools#449)
  move Groups to property, add policy template version (cloudtools#460)
  ...
amosshapira pushed a commit to amosshapira/troposphere that referenced this issue Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants