Update Contribute Document to Use Requirements.txt #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions tested with python 2.7.
|
I think the dev dependencies listed in the docs/requirements.txt file should not be pinned to specific versions. |
|
@philtay - Great point. I removed the version pinning. |
|
Thanks! |
webratz
pushed a commit
to webratz/troposphere
that referenced
this pull request
May 4, 2016
* cloudtools/master: (80 commits) Add test for AWS::Logs::Destination (cloudtools#482) Fix baseclass for AWS::Logs::Destination (Fixes cloudtools#481) Update for changes since 1.5.0 Fix Bucket AccessControl to allow Ref (cloudtools#475) Better AWSHelperFn support in template generator (cloudtools#473) Implement LifecycleRule Transitions property (cloudtools#472) Update to Apr 25, 2016 release (cloudtools#471) Fix Source object to take a list of SourceDetails (cloudtools#469) Update Contribute Document to Use Requirements.txt (cloudtools#470) Add WAF SizeConstraintSet and XssMatchSet Add backward compatibility for the deprecated ElasticsearchDomain Fix Elasticsarch Domain object naming Import JSON Templates (cloudtools#468) ReplicationConfigurationRules Destination is now an object (cloudtools#380) Remove unnecessary AWSHelperFn from props EC2 update FromPort, ToPort and Egress as optional Added CloudWatch Events support ApiGateway Resources (cloudtools#466) Provide Valid Lambda Function Memory Values for use in Parameters (cloudtools#449) move Groups to property, add policy template version (cloudtools#460) ...
amosshapira
pushed a commit
to amosshapira/troposphere
that referenced
this pull request
Oct 24, 2016
Add requirements doc for python. Versions tested with python 2.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a minor simplification change to the
CONTRIBUTE.mddocument. Instead of listing all the commands for installing modules, I put the modules into arequirements.txtfile (viapip freeze) and then updated the docs on how to use the new file.This change should help with
codedocumentation rot.One possible improvement is to use
>=on the versioning, but would only want to do that if the CI tests always used the bleeding edge version.