Cloudfront cache and origin policy #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for OriginRequestPolicy and CachePolicy with relative check in validators.py.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Cloudfront CachePolicy and OriginRequestPolicy with proper validators.
Tested creation with a template containing both CachePolicy and OriginRequestPolicy.
Note:
You cannot set MaxTLL = MinTLL = DefaultTTL = 0 in CachePolicyConfig.
If you do this CloudFormation give error ("Invalid request provided: AWS::CloudFront::CachePolicy").
By WebGui if you set all to zero you are no more able to configure ParametersInCacheKeyAndForwardedToOrigin's parameters as Cookie, Headers and QueryStrings.
This is probably the root cause of the error.
(ParametersInCacheKeyAndForwardedToOrigin is always required, so omitting it is not a solution)
In that case just set MaxTLL to one (maybe AWS will fix this in the future).