extended title validation #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 5, 2016 08:26
also adding an option do define own title checks IAM limits are documented at http://docs.aws.amazon.com/IAM/latest/UserGuide/reference_iam-limits.html
| # unset/None is also legal | ||
| if title and not valid_names.match(title): | ||
| # some objects allow more characters than others | ||
| if title and 'validate_title' in dir(self): |
There was a problem hiding this comment.
Does it maybe make more sense to do away with this logic and instead move the valid_names.match into a default validate_title method? It'd make this a bit cleaner. This would become:
if title:
self.validate_title()
…en for custom title validators
|
You are right, this is a nicer way to implement this. Updated the PR |
| if title and not valid_names.match(title): | ||
| raise ValueError('Name "%s" not alphanumeric' % title) | ||
| # try to validate the title if its there | ||
| if self.title is not None: |
There was a problem hiding this comment.
if self.title is more pythonic, and should do what you want here. Otherwise I think this is good to go.
|
updated |
|
Awesome, thanks @webratz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to have custom title validators, as the default one is often to restrictive (AWS allows more characters)
Also there are some new checks for IAM Objects which help you catching errors before you run the CF template.