Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DependsOn to Deployment and remove Enabled from StageKey #519

Merged
merged 2 commits into from
Jul 6, 2016
Merged

Add DependsOn to Deployment and remove Enabled from StageKey #519

merged 2 commits into from
Jul 6, 2016

Conversation

therockstorm
Copy link
Contributor

DependsOn is required if the RestApi and Method are created in the same template as explained here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-deployment.html#aws-resource-apigateway-deployment-examples

@markpeek
Copy link
Member

markpeek commented Jul 2, 2016

This change requires a corresponding update to tests/examples_output/ApiGateway.template in order to pass the tests.

@markpeek markpeek merged commit 4c73735 into cloudtools:master Jul 6, 2016
@markpeek
Copy link
Member

markpeek commented Jul 6, 2016

Thanks!

@therockstorm therockstorm deleted the api-gateway branch July 6, 2016 18:37
amosshapira pushed a commit to amosshapira/troposphere that referenced this pull request Oct 24, 2016
…ols#519)

* Add DependsOn to Deployment and remove Enabled from StageKey
* Update ApiGateway.template to match changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants