Add a validator for ELB names #615
Conversation
| @@ -73,6 +73,14 @@ def test_s3_bucket_name(self): | |||
| with self.assertRaises(ValueError): | |||
| s3_bucket_name(b) | |||
|
|
|||
| def test_elb_name(self): | |||
| for b in ['a', 'a'*32, 'wick3d-elb-name', 'Wick3d-ELB-Name']: | |||
There was a problem hiding this comment.
Given the regex you might want to add:
a-a
aa
aaa
There was a problem hiding this comment.
Added in 9b55342
| def test_elb_name(self): | ||
| for b in ['a', 'a'*32, 'wick3d-elb-name', 'Wick3d-ELB-Name']: | ||
| elb_name(b) | ||
| for b in ['a'*63, 'invalid_elb', '-invalid-elb', |
There was a problem hiding this comment.
Probably want 'a'*33 instead of 63. Add 'a-' as well.
There was a problem hiding this comment.
Good catch. Copy pasta. Fixed and expanded in 9b55342
| @@ -73,6 +73,14 @@ def s3_bucket_name(b): | |||
| raise ValueError("%s is not a valid s3 bucket name" % b) | |||
|
|
|||
|
|
|||
| def elb_name(b): | |||
| elb_name_re = compile(r'^[a-zA-Z0-9][a-zA-Z0-9\-]{0,30}[a-zA-Z0-9]{1}$') | |||
There was a problem hiding this comment.
Try something like this:
^[a-zA-Z0-9](?:[a-zA-Z0-9\-]{0,30}[a-zA-Z0-9]{1})?$
There was a problem hiding this comment.
This worked! Nice call. I've added it here: 9b55342
I tested manually a bit on http://pythex.org/ just for context.
|
@markpeek - Thanks for the help on this. It looks to have passed the tests. Do you want me to squash the commits before you accept it? |
|
@chrisgilmerproj thanks for making the changes. I'll have time to review further and commit later. I'll squash as part of the github commit flow. |
|
I appreciate it. Thanks so much. |
|
Thanks! |
The LoadBalancerName has some constraints that we can validate for ahead of time:
From: http://docs.aws.amazon.com/elasticloadbalancing/2012-06-01/APIReference/API_CreateLoadBalancer.html
My current implementation of the regex doesn't quite work. A one character name ought to work but I have created a regex that will fail on names of one character. I could use some help on it.