Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDTRUST-2435 2436] trustID groups management #203

Merged
merged 1 commit into from
Mar 23, 2020
Merged

[CLOUDTRUST-2435 2436] trustID groups management #203

merged 1 commit into from
Mar 23, 2020

Conversation

fperot74
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 20, 2020 •
edited

Pull Request Test Coverage Report for Build 1977

  • 56 of 56 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 92.159%
Totals Coverage Status
Change from base Build 1973: 0.06%
Covered Lines: 5430
Relevant Lines: 5892
💛 - Coveralls

bsoniam
bsoniam approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@bsoniam bsoniam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for naming, otherwise ok

api/management/swagger-api_management.yaml Show resolved Hide resolved
cmd/keycloakb/keycloak_bridge.go Outdated Show resolved Hide resolved
pkg/management/component.go Show resolved Hide resolved
pkg/management/component.go Show resolved Hide resolved
@fperot74 fperot74 mentioned this pull request Mar 23, 2020
Closed
@bsoniam bsoniam self-requested a review March 23, 2020 08:53
@fperot74 fperot74 merged commit 24473e6 into cloudtrust:master Mar 23, 2020
@fperot74 fperot74 deleted the ct-2436-gettrustidgroups branch March 23, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harture harture harture approved these changes

@bsoniam bsoniam bsoniam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fperot74 @coveralls @harture @bsoniam