-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOUDTRUST-2438] Remove parameter groupIDs from GET /kyc/users #204
Conversation
pkg/kyc/authorization.go
Outdated
@@ -68,17 +68,15 @@ func (c *authorizationComponentMW) GetActions(ctx context.Context) ([]apikyc.Act | |||
return c.next.GetActions(ctx) | |||
} | |||
|
|||
func (c *authorizationComponentMW) GetUserByUsername(ctx context.Context, username string, groupIDs []string) (apikyc.UserRepresentation, error) { | |||
func (c *authorizationComponentMW) GetUserByUsername(ctx context.Context, username string) (apikyc.UserRepresentation, error) { | |||
var action = KYCGetUserByUsername.String() | |||
var targetRealm = c.realmName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using realmName of the MW coming from configuration. I think it should depend of the current user and thus using the value present in context. Am I missing something ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right... fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue seems to also applies to the others methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-fixed
Pull Request Test Coverage Report for Build 1985
💛 - Coveralls |
5c90ea3
to
ce500c0
Compare
ce500c0
to
7dff0b9
Compare
No description provided.