[CLOUDTRUST-2438] Remove parameter groupIDs from GET /kyc/users #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harture
reviewed
Mar 20, 2020
pkg/kyc/authorization.go
Outdated
| @@ -68,17 +68,15 @@ func (c *authorizationComponentMW) GetActions(ctx context.Context) ([]apikyc.Act | |||
| return c.next.GetActions(ctx) | |||
| } | |||
|
|
|||
| func (c *authorizationComponentMW) GetUserByUsername(ctx context.Context, username string, groupIDs []string) (apikyc.UserRepresentation, error) { | |||
| func (c *authorizationComponentMW) GetUserByUsername(ctx context.Context, username string) (apikyc.UserRepresentation, error) { | |||
| var action = KYCGetUserByUsername.String() | |||
| var targetRealm = c.realmName | |||
There was a problem hiding this comment.
We are using realmName of the MW coming from configuration. I think it should depend of the current user and thus using the value present in context. Am I missing something ?
There was a problem hiding this comment.
This issue seems to also applies to the others methods
Pull Request Test Coverage Report for Build 1985
💛 - Coveralls |
bsoniam
approved these changes
Mar 23, 2020
fperot74
force-pushed
the
ct-2438-kycusers
branch
2 times, most recently
from
5c90ea3
to
ce500c0
Compare
fperot74
force-pushed
the
ct-2438-kycusers
branch
from
ce500c0
to
7dff0b9
Compare
harture
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.