Add methods to provide list of events to back-office #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 377
💛 - Coveralls |
fperot74
force-pushed
the
retrieve-events
branch
from
6059025
to
3f3da13
Compare
fperot74
force-pushed
the
retrieve-events
branch
3 times, most recently
from
8fb09c9
to
2906f0a
Compare
harture
reviewed
Apr 23, 2019
| Message: fmt.Sprintf("Duplicated parameter %s", key), | ||
| } | ||
| } | ||
| request[key] = value |
There was a problem hiding this comment.
For realm key, we will override the one provided by the path parameter.
Maybe rename it target_realm would solve the issue.
harture
reviewed
Apr 23, 2019
fperot74
force-pushed
the
retrieve-events
branch
from
3362add
to
ae50e0c
Compare
…nts to back-office
… of events to back-office
harture
reviewed
Apr 24, 2019
| @@ -31,7 +31,7 @@ func MakeGetEventsSummaryEndpoint(ec EventsComponent) endpoint.Endpoint { | |||
| // MakeGetUserEventsEndpoint makes the events summary endpoint. | |||
| func MakeGetUserEventsEndpoint(ec EventsComponent) endpoint.Endpoint { | |||
| return func(ctx context.Context, req interface{}) (interface{}, error) { | |||
| params := filterParameters(req.(map[string]string), "first", "max", "dateFrom", "dateTo", "realm", "userID", "origin", "ctEventType") | |||
| params := filterParameters(req.(map[string]string), "first", "max", "dateFrom", "dateTo", "realm", "realmTarget", "userID", "origin", "ctEventType") | |||
There was a problem hiding this comment.
On devrait pas enelver realm ici ?
harture
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.