[KEYCLOAK-11746] More unit tests: browser flow #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlistairDoswald
suggested changes
Oct 22, 2019
| } | ||
|
|
||
| private static void addAuthenticatorExecutionSubFlow(RealmModel realm, Requirement requirement, int priority, AuthenticationFlowModel subFlow, AuthenticationFlowModel parentFlow) { | ||
| AuthenticationExecutionModel execution = new AuthenticationExecutionModel(); |
There was a problem hiding this comment.
I think we can do a bit better here: have the method create the flow and the executor.
| } | ||
|
|
||
| private static void addAuthenticatorExecution(RealmModel realm, Requirement requirement, String providerId, int priority, AuthenticationFlowModel parentFlow) { |
There was a problem hiding this comment.
These methods are really useful, and I think that we would benefit from moving them to a util class rather than just keeping them here. For example, they could also be used to simplify the code in KcOidcFirstBrokerLoginNewAuthTest
AlistairDoswald
suggested changes
Oct 22, 2019
| return this; | ||
| } | ||
|
|
||
| public void activateFlow() { |
There was a problem hiding this comment.
This will be used for more than just browser flows. So either the tool should know which flow to replace from a previous step, or it should be defined here.
fperot74
force-pushed
the
multi-token-tests
branch
from
cf6a6c4
to
50060a9
Compare
fperot74
force-pushed
the
multi-token-tests
branch
from
50060a9
to
b2fde54
Compare
|
Replaced by #19 |
lagess
pushed a commit
to lagess/keycloak
that referenced
this pull request
Mar 3, 2023
lagess
pushed a commit
to lagess/keycloak
that referenced
this pull request
Mar 3, 2023
…loak#17380) Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com> (cherry picked from commit ec81091)
lagess
pushed a commit
that referenced
this pull request
Mar 6, 2023
…session (#18) (keycloak#17380) (cherry picked from commit e2b5cb4)
lagess
pushed a commit
to lagess/keycloak
that referenced
this pull request
Apr 17, 2023
lagess
pushed a commit
to lagess/keycloak
that referenced
this pull request
Apr 17, 2023
* KEYCLOAK-15527 Adding context to master.adoc and index.adoc to allow reuse * KEYCLOAK-15614 modularisation of 'Creating an Open ID Connect Client' (cloudtrust#14) * More changes based on feedback * Puts back 2 out of 3 screens * KEYCLOAK-15614 updates to anchors * Minor spelling correction in Getting Started * Keycloak 15786 (cloudtrust#16) * rebase corrections * post feedback changes * post review changes (cloudtrust#18) * KEYCLOAK-15616 initial commit Co-authored-by: Andy Munro <amunro@redhat.com>
lagess
pushed a commit
to lagess/keycloak
that referenced
this pull request
Apr 17, 2023
…loak#17380) (keycloak#17389) Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.