Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Optimizing hertz observability #845

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

rogerogers
Copy link
Contributor

@rogerogers rogerogers commented Oct 28, 2023

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional): 优化 hertz 可观测性文档

(Optional) Which issue(s) this PR fixes:

Fixes hertz-contrib/obs-opentelemetry#25

@rogerogers rogerogers requested review from a team as code owners October 28, 2023 05:52
@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudwego ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 2:10am

Signed-off-by: rogerogers <rogers@rogerogers.com>
@rogerogers rogerogers marked this pull request as ready for review October 30, 2023 07:36
@rogerogers rogerogers changed the title [WIP] chore: Optimizing hertz observability chore: Optimizing hertz observability Oct 30, 2023
@GuangmingLuo
Copy link
Member

@CoderPoet Please take a look.

Signed-off-by: rogerogers <rogers@rogerogers.com>
Signed-off-by: rogerogers <rogers@rogerogers.com>
@li-jin-gou li-jin-gou merged commit 804f238 into cloudwego:main Oct 31, 2023
4 checks passed
@rogerogers rogerogers deleted the chore/obs branch October 31, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Question: purpose of injectStatsEventsToSpan
4 participants