Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: purpose of injectStatsEventsToSpan #25

Closed
a631807682 opened this issue Oct 17, 2023 · 4 comments · Fixed by cloudwego/cloudwego.github.io#845
Closed

Question: purpose of injectStatsEventsToSpan #25

a631807682 opened this issue Oct 17, 2023 · 4 comments · Fixed by cloudwego/cloudwego.github.io#845
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@a631807682
Copy link
Member

a631807682 commented Oct 17, 2023

Describe the question

I see we inject a lot of event into the span. I would like to know the purpose of these indicators and thus determine what I should do with them. Now when I look at the logs (either in jaeger or kibana) it's a little messy.

https://github.com/hertz-contrib/obs-opentelemetry/blob/main/tracing/tracer_server.go#L117

(We seem to be missing a question template)

@rogerogers
Copy link
Collaborator

These events label the time information of some important nodes in the request lifecycle, and they can be disabled through configuration if not needed.

server.Default(tracer, server.WithTraceLevel(stats.LevelBase))
// or
server.Default(tracer, server.WithTraceLevel(stats.LevelDisabled))

@rogerogers
Copy link
Collaborator

Kitex has documentation observability/instrumentation, but it seems that Hertz is missing this part of the documentation.

cc @li-jin-gou

@a631807682
Copy link
Member Author

Thanks for your reply, I have no further questions, if it's related to the documentation I'll keep it open, otherwise I'll close it.

@li-jin-gou
Copy link
Contributor

li-jin-gou commented Oct 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants