Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for partition cookies #929

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

Haswf
Copy link
Contributor

@Haswf Haswf commented Jan 12, 2024

What type of PR is this?

docs

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

添加分区 Cookie 的文档

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: add documentation for partition cookies as discussed in cloudwego/hertz#1047.
zh(optional):

(Optional) Which issue(s) this PR fixes:

Fixes cloudwego/hertz#1047

@Haswf Haswf requested review from a team as code owners January 12, 2024 13:44
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudwego ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2024 2:49pm

@li-jin-gou
Copy link
Member

li-jin-gou commented Jan 12, 2024

这个 MR 依赖 cloudwego/hertz#1048 发版, 文档是否可以先不添加 Set-Cookie 的改动。

好像不行..

@Haswf
Copy link
Contributor Author

Haswf commented Jan 12, 2024

这个 MR 依赖 cloudwego/hertz#1048 发版, 文档是否可以先不添加 Set-Cookie 的改动。

好像不行..

啥时候发下个小版本?现在复制SetCookie的办法感觉不大能写到官方文档上去,万一以后SetCookie的行为改了,就不好维护了。

@li-jin-gou
Copy link
Member

这个 MR 依赖 cloudwego/hertz#1048 发版, 文档是否可以先不添加 Set-Cookie 的改动。
好像不行..

啥时候发下个小版本?现在复制SetCookie的办法感觉不大能写到官方文档上去,万一以后SetCookie的行为改了,就不好维护了。

可以先给一个方案,小版本正常是双周...

@li-jin-gou li-jin-gou merged commit 20cffd5 into cloudwego:main Jan 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Feature request: add docs for https://github.com/cloudwego/hertz/pull/1041
3 participants