Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Partitioned Parameter to SetCookie #1048

Merged
merged 3 commits into from
May 9, 2024

Conversation

Haswf
Copy link
Contributor

@Haswf Haswf commented Jan 12, 2024

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat: SetCookie 增加 Partitioned 参数

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
As discuessed, this PR adds partitioned parameter to (*RequestContext).SetCookie, simplifying the use of partitioned cookies.

zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

Yes, see cloudwego/cloudwego.github.io#929 for related doc changes.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d25abe) 82.49% compared to head (3f1e84f) 82.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1048      +/-   ##
===========================================
+ Coverage    82.49%   82.55%   +0.05%     
===========================================
  Files           98       98              
  Lines        10025    10030       +5     
===========================================
+ Hits          8270     8280      +10     
+ Misses        1258     1254       -4     
+ Partials       497      496       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/app/context.go Outdated Show resolved Hide resolved
@Haswf Haswf requested a review from welkeyever February 1, 2024 03:03
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@li-jin-gou li-jin-gou merged commit b5b3f9d into cloudwego:develop May 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants