Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing port when use domain #154

Merged
merged 2 commits into from
Jul 26, 2022
Merged

fix: add missing port when use domain #154

merged 2 commits into from
Jul 26, 2022

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Jul 26, 2022

What type of PR is this?

  • fix

What this PR does / why we need it (English/Chinese):

  • en: add missing port when use domain
  • zh: 使用域名时添加默认端口

Which issue(s) this PR fixes:

Duslia
Duslia previously approved these changes Jul 26, 2022
Duslia
Duslia previously approved these changes Jul 26, 2022
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@li-jin-gou li-jin-gou merged commit acdb793 into cloudwego:develop Jul 26, 2022
@li-jin-gou li-jin-gou deleted the fix/miss_port branch September 25, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants