Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(hlog): distinguish systemlogger and defaultlogger #266

Merged
merged 1 commit into from
Oct 10, 2022
Merged

optimize(hlog): distinguish systemlogger and defaultlogger #266

merged 1 commit into from
Oct 10, 2022

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Sep 21, 2022

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

区分系统日志和默认日志

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: distinguish systemlogger and defaultlogger
zh: 区分系统日志和默认日志

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 61.57% // Head: 64.35% // Increases project coverage by +2.78% 🎉

Coverage data is based on head (e1b0cd9) compared to base (202fe6a).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #266      +/-   ##
===========================================
+ Coverage    61.57%   64.35%   +2.78%     
===========================================
  Files           84       84              
  Lines         8288     8288              
===========================================
+ Hits          5103     5334     +231     
+ Misses        2831     2592     -239     
- Partials       354      362       +8     
Impacted Files Coverage Δ
pkg/app/client/loadbalance/lbcache.go 79.45% <0.00%> (ø)
pkg/app/client/loadbalance/weight_random.go 88.09% <0.00%> (ø)
pkg/network/netpoll/transport.go 0.00% <0.00%> (ø)
pkg/network/standard/transport.go 0.00% <0.00%> (ø)
pkg/protocol/http1/client.go 35.86% <0.00%> (ø)
pkg/app/fs.go 68.65% <10.00%> (ø)
pkg/route/engine.go 62.06% <11.11%> (ø)
pkg/app/server/render/html.go 37.50% <77.77%> (ø)
pkg/app/server/hertz.go 75.00% <80.00%> (ø)
internal/stats/tracer.go 90.00% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou li-jin-gou changed the title optimize: optimize the hlog experience (wip)optimize: optimize the hlog experience Sep 22, 2022
@li-jin-gou li-jin-gou changed the title (wip)optimize: optimize the hlog experience optimize: optimize the hlog experience Sep 26, 2022
@li-jin-gou li-jin-gou changed the title optimize: optimize the hlog experience optimize(hlog): distinguish systemlogger and defaultlogger Sep 27, 2022
@li-jin-gou li-jin-gou changed the title optimize(hlog): distinguish systemlogger and defaultlogger optimize(hlog): distinguish systemlogger and defaultlogger, and add SetCallDepth interface. Sep 27, 2022
pkg/common/hlog/log.go Outdated Show resolved Hide resolved
pkg/common/hlog/default.go Outdated Show resolved Hide resolved
Duslia
Duslia previously approved these changes Sep 30, 2022
@li-jin-gou li-jin-gou changed the title optimize(hlog): distinguish systemlogger and defaultlogger, and add SetCallDepth interface. optimize(hlog): distinguish systemlogger and defaultlogger Sep 30, 2022
pkg/common/hlog/hlog.go Outdated Show resolved Hide resolved
pkg/common/hlog/hlog.go Outdated Show resolved Hide resolved
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@li-jin-gou li-jin-gou merged commit f08a489 into cloudwego:develop Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants