test: increase internal/bytesconv unit test statement coverage #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
li-jin-gou
requested review from
li-jin-gou,
Duslia,
FGYFFFF and
welkeyever
|
CI need to resolve |
|
OK, thanks. |
Alexdener
force-pushed
the
feat-ut-bytesconv
branch
from
287e039
to
c1618cc
Compare
Alexdener
force-pushed
the
feat-ut-bytesconv
branch
from
43c0c6e
to
4c4f6a3
Compare
FGYFFFF
reviewed
Sep 26, 2022
FGYFFFF
reviewed
Sep 26, 2022
FGYFFFF
reviewed
Sep 26, 2022
Codecov ReportBase: 61.57% // Head: 62.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #274 +/- ##
===========================================
+ Coverage 61.57% 62.76% +1.19%
===========================================
Files 84 84
Lines 8288 8288
===========================================
+ Hits 5103 5202 +99
+ Misses 2831 2728 -103
- Partials 354 358 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Duslia
reviewed
Sep 26, 2022
Alexdener
requested review from
FGYFFFF and
Duslia
and removed request for
welkeyever,
li-jin-gou,
FGYFFFF and
Duslia
resolved |
Duslia
approved these changes
Oct 2, 2022
welkeyever
approved these changes
Oct 8, 2022
welkeyever
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
test: internal/bytesconv unit test statement coverage from 1.68% to 82.35%
Check the PR title.
This PR title match the format: (optional scope):
The description of this PR title is user-oriented and clear enough for others to understand.
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: internal/bytesconv unit test statement coverage from 1.68% to 82.35%
zh(optional): 增加internal/bytesconv包测试覆盖率，覆盖率从1.68%提高到了82.35%
Which issue(s) this PR fixes:
part of #257