Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request help: Supplementary of Unit Tests #257

Open
12 of 15 tasks
welkeyever opened this issue Sep 19, 2022 · 58 comments · Fixed by #808 or #1074
Open
12 of 15 tasks

Request help: Supplementary of Unit Tests #257

welkeyever opened this issue Sep 19, 2022 · 58 comments · Fixed by #808 or #1074
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@welkeyever
Copy link
Member

welkeyever commented Sep 19, 2022

We hope more developers join CloudWeGo. This is a task issue that needs your help.

Issue Description
Write Unit Tests for some modules of Hertz, we mainly focus on Statement Coverage. The packages are shown below, you can choose and reply by comment.
Before you pick the task, please comply with the following requirements:

  • The Unit Test you add must be meaningful.
    • It is used to verify the correctness of code logic.
    • It is forbidden to add a test only for the purpose of coverage but without logical meaning.
  • It is suggested to add comments with clear descriptions for each unit test.
  • Every unit test must have assertions.
  • Don't check code logic by print.

Packages

Current Coverages v0.3.1.


  • pkg/app: Current 70.87%, Target 80%, by @chaoranz758
  • pkg/route: Current 78.49%, Target 85%, by
  • pkg/protocol/http1: Current 33.94%, Target 80%, by @a631807682
  • pkg/protocol/uri.go: Current 70.35%, Target 80%, Raised to 86.4%, by @L2ncE
  • pkg/protocol/args.go: Current 56.57%, Target 80%, Raised to 81.3%, by @justlorain
  • pkg/protocol/header.go: Current 74.25%, Target 80%, by @XiaoYi-byte
  • pkg/protocol/request.go: Current 51.31%, Target 80%, Raised to 85.3%, by @BaiZe1998
  • pkg/protocol/response.go: Current 60.14%(Overall 56%), Target 80%, Raised to 81.8% by @gityh2021
  • pkg/protocol/multipart.go: Current 20.25%, Target 80%, Raised to 79.75%, by @gityh2021
  • pkg/network: Current 68.14%, Target 80%, Raised to 95.2%, by @a631807682
  • pkg/common/utils: Current 72.34%, Target 80%, by
  • pkg/common/config: Current 32.91%, Target 80%, Raised to 100%, by @rogerogers
  • pkg/common/adaptor: Current 76.60%, Target 85%, Raised to 91.5%, by @L2ncE
  • internal/bytesconv: Current 1.68%, Target 80%, Raised to 82.35%, by @Alexdener
  • pkg/common/test: Current 3.2%, Target 80%, Raised to 98.1% by @a631807682

Standard coverage stats: https://app.codecov.io/gh/cloudwego/hertz

@welkeyever welkeyever added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 19, 2022
@BaiZe1998
Copy link
Contributor

i want to be in charge of pkg/network

@li-jin-gou
Copy link
Member

i want to be in charge of pkg/network

thanks

@rogerogers
Copy link
Contributor

I want to do pkg/common/config

@li-jin-gou
Copy link
Member

I want to do pkg/common/config

thanks

@KevinChens
Copy link

I want to do pkg/app

@li-jin-gou
Copy link
Member

@KevinChens thanks

@L2ncE
Copy link
Member

L2ncE commented Sep 20, 2022

I want to do pkg/common/adaptor

@li-jin-gou
Copy link
Member

@L2ncE thanks

@justlorain
Copy link
Member

I'd like to try pkg/protocol/args.go.

@li-jin-gou
Copy link
Member

I'd like to try pkg/protocol/args.go.

thanks

@Alexdener
Copy link
Contributor

Can I try internal/bytesconv?

@li-jin-gou
Copy link
Member

Can I try internal/bytesconv?

thanks

@L2ncE
Copy link
Member

L2ncE commented Sep 26, 2022

Can I try again and take charge of the pkg/protocol/uri.go?

@li-jin-gou
Copy link
Member

Can I try again and take charge of the pkg/protocol/uri.go?

thanks

@keyvan-dadash
Copy link
Contributor

can i try pkg/common/utils?

@li-jin-gou
Copy link
Member

can i try pkg/common/utils?

thanks

@sjcsjc123
Copy link
Contributor

i want to try pkg/common/utils, thanks

@li-jin-gou
Copy link
Member

i want to try pkg/common/utils, thanks

thanks

@ViolaPioggia
Copy link
Member

Can I try pkg/protocol/multipart.go ?

@welkeyever
Copy link
Member Author

Can I try pkg/protocol/multipart.go ?

@ViolaPioggia PR is open~

@liuxianloveqiqi
Copy link
Contributor

Can I still try pkg/common/utils?

@li-jin-gou
Copy link
Member

Can I still try pkg/common/utils?

thanks

@HzTTT
Copy link
Contributor

HzTTT commented Nov 9, 2023

Can I try pkg/route ?

@li-jin-gou
Copy link
Member

Can I try pkg/route ?

Thanks

@PolarishT
Copy link

pkg/common/utils can I hava a try?

@li-jin-gou
Copy link
Member

pkg/common/utils can I hava a try?

Thanks

@li-jin-gou li-jin-gou unpinned this issue Feb 18, 2024
@onenewcode
Copy link

Can I try ? pkg/protocol/header.go

@XiaoYi-byte
Copy link
Contributor

I want to try pkg/protocol/header.go

@li-jin-gou
Copy link
Member

Can I try ? pkg/protocol/header.go

Sorry for not seeing the comments on the issue until now.

@li-jin-gou
Copy link
Member

I want to try pkg/protocol/header.go

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment